Comments on: TDD: Listen to the tests… they tell smells in your code! http://blog.m.artins.net/tdd-listen-to-the-tests-they-tell-smells-in-your-code/ On Agile Software Development Sun, 26 Dec 2010 03:22:16 +0000 hourly 1 http://wordpress.org/?v=3.0.1 By: Alexandre Martins http://blog.m.artins.net/tdd-listen-to-the-tests-they-tell-smells-in-your-code/comment-page-1/#comment-13644 Alexandre Martins Tue, 27 Jul 2010 14:49:52 +0000 http://blog.m.artins.net/?p=305#comment-13644 @Chris Vest Thanks dude! Already fixed... The idea of test coverings looks pretty cool. Never heard of it, will check it out as soon as I find my "Legacy Code" copy. Thanks for the tip! @Chris Vest
Thanks dude! Already fixed…
The idea of test coverings looks pretty cool.
Never heard of it, will check it out as soon as I find my “Legacy Code” copy.
Thanks for the tip!

]]> By: Chris Vest http://blog.m.artins.net/tdd-listen-to-the-tests-they-tell-smells-in-your-code/comment-page-1/#comment-13632 Chris Vest Tue, 27 Jul 2010 09:45:54 +0000 http://blog.m.artins.net/?p=305#comment-13632 You second Paperboy class is missing a `totalCollected.add(amountPaid);` line. It can be dangerous to refactor without adequate test coverage. Therefor you need the big "tests" to gain coverage - Michael Feathers calls them test coverings. Once you have those, you can iterate on refactoring the product code for testability and write a new set of small test cases. And when you new set of tests overtake the test coverings in coverage (or something), then you can delete the coverings. A covering is certainly painful to write, but they are temporary things and they allow us to work more effectively with the legacy code going forward. You second Paperboy class is missing a `totalCollected.add(amountPaid);` line.

It can be dangerous to refactor without adequate test coverage. Therefor you need the big “tests” to gain coverage – Michael Feathers calls them test coverings. Once you have those, you can iterate on refactoring the product code for testability and write a new set of small test cases. And when you new set of tests overtake the test coverings in coverage (or something), then you can delete the coverings. A covering is certainly painful to write, but they are temporary things and they allow us to work more effectively with the legacy code going forward.

]]> By: Pavol Bernhauser http://blog.m.artins.net/tdd-listen-to-the-tests-they-tell-smells-in-your-code/comment-page-1/#comment-13630 Pavol Bernhauser Tue, 27 Jul 2010 08:07:05 +0000 http://blog.m.artins.net/?p=305#comment-13630 Very good article and description. I am bookmarking it so I can find it in future when I will try to describe this idea to somebody. But there is a small glitch in "correct" example. Paid money is not added to totalCollected. Very good article and description. I am bookmarking it so I can find it in future when I will try to describe this idea to somebody.
But there is a small glitch in “correct” example. Paid money is not added to totalCollected.

]]>